Re: [Qemu-devel] [RFC] e1000: Faulty tx checksum offload corrupts packets

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [RFC] e1000: Faulty tx checksum offload corrupts packets

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
384d619695 e1000: Faulty tx checksum offload corrupts packets

=== OUTPUT BEGIN ===
Checking PATCH 1/1: e1000: Faulty tx checksum offload corrupts packets...
ERROR: line over 90 characters
#127: FILE: hw/net/e1000.c:549:
+        DBGOUT(TXERR, "txsum bug! ver %d src %08x dst %08x len %d proto %d 
cptse %d sum_needed %x oldsum %x newsum %x realsum %x\n",

ERROR: braces {} are necessary for all arms of this statement
#169: FILE: hw/net/e1000.c:584:
+        if (tp->tso_props.tcp) {
[...]
             }
[...]

ERROR: line over 90 characters
#230: FILE: hw/net/e1000.c:644:
+    DBGOUT(TXERR, "context descriptor: tse %d ip %d tcp %d ipcss %d ipcso %d 
ipcse %d tucss %d tucso %d tucse %d\n",

WARNING: line over 80 characters
#322: FILE: hw/net/e1000.c:731:
+            if (sz >= tp->tso_props.hdr_len && tp->size < 
tp->tso_props.hdr_len) {

ERROR: do not use C99 // comments
#402: FILE: hw/net/e1000x_common.h:196:
+    unsigned char sum_needed; // doesn't belong here

ERROR: do not use C99 // comments
#411: FILE: hw/net/e1000x_common.h:209:
+    bool cptse; // doesn't belong here

ERROR: Missing Signed-off-by: line(s)

total: 6 errors, 1 warnings, 299 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden