[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 18/24] fixup! ppc: spapr: use generic cpu_mod
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH v2 18/24] fixup! ppc: spapr: use generic cpu_model parsing |
Date: |
Fri, 13 Oct 2017 09:24:09 +1100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Thu, Oct 12, 2017 at 05:50:08PM +0200, Igor Mammedov wrote:
> inot sure how it managed to compile locally and on travis
Because target/ppc/kvm.c is only compiled on a ppc _host_.
> but build fails with type mismatch on PPC host, fixup it
> by casting to expected type
I already hit this one and fixed it up in place.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> target/ppc/kvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
> index 48dc3f7..9d57deb 100644
> --- a/target/ppc/kvm.c
> +++ b/target/ppc/kvm.c
> @@ -2505,7 +2505,7 @@ static int kvm_ppc_register_host_cpu_type(MachineState
> *ms)
> }
> type_info.parent = object_class_get_name(OBJECT_CLASS(pvr_pcc));
> type_register(&type_info);
> - if (object_dynamic_cast(ms, TYPE_SPAPR_MACHINE)) {
> + if (object_dynamic_cast(OBJECT(ms), TYPE_SPAPR_MACHINE)) {
> /* override TCG default cpu type with 'host' cpu model */
> mc->default_cpu_type = TYPE_HOST_POWERPC_CPU;
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v2 14/24] fixup! ppc: spapr: use cpu type name directly, (continued)
- [Qemu-devel] [PATCH v2 19/24] ppc: pnv: use generic cpu_model parsing, Igor Mammedov, 2017/10/09
- [Qemu-devel] [PATCH v2 20/24] ppc: pnv: normalize core/chip type names, Igor Mammedov, 2017/10/09
- [Qemu-devel] [PATCH v2 21/24] ppc: pnv: drop PnvCoreClass::cpu_oc field, Igor Mammedov, 2017/10/09
- [Qemu-devel] [PATCH v2 22/24] ppc: pnv: define core types statically, Igor Mammedov, 2017/10/09
- [Qemu-devel] [PATCH v2 24/24] ppc: pnv: consolidate type definitions and batch register them, Igor Mammedov, 2017/10/09
- [Qemu-devel] [PATCH v2 23/24] ppc: pnv: drop PnvChipClass::cpu_model field, Igor Mammedov, 2017/10/09