[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 11/20] translate-all: define and use DEBUG_TB_FLUS
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL v2 11/20] translate-all: define and use DEBUG_TB_FLUSH_GATE |
Date: |
Tue, 10 Oct 2017 12:29:54 -0700 |
From: "Emilio G. Cota" <address@hidden>
This gets rid of some ifdef checks while ensuring that the debug code
is compiled, which prevents bit rot.
Suggested-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
accel/tcg/translate-all.c | 20 +++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index ed65d68709..799b027e79 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -65,6 +65,12 @@
/* make various TB consistency checks */
/* #define DEBUG_TB_CHECK */
+#ifdef DEBUG_TB_FLUSH
+#define DEBUG_TB_FLUSH_GATE 1
+#else
+#define DEBUG_TB_FLUSH_GATE 0
+#endif
+
#if !defined(CONFIG_USER_ONLY)
/* TB consistency checks only implemented for usermode emulation. */
#undef DEBUG_TB_CHECK
@@ -899,13 +905,13 @@ static void do_tb_flush(CPUState *cpu, run_on_cpu_data
tb_flush_count)
goto done;
}
-#if defined(DEBUG_TB_FLUSH)
- printf("qemu: flush code_size=%ld nb_tbs=%d avg_tb_size=%ld\n",
- (unsigned long)(tcg_ctx.code_gen_ptr - tcg_ctx.code_gen_buffer),
- tcg_ctx.tb_ctx.nb_tbs, tcg_ctx.tb_ctx.nb_tbs > 0 ?
- ((unsigned long)(tcg_ctx.code_gen_ptr - tcg_ctx.code_gen_buffer)) /
- tcg_ctx.tb_ctx.nb_tbs : 0);
-#endif
+ if (DEBUG_TB_FLUSH_GATE) {
+ printf("qemu: flush code_size=%td nb_tbs=%d avg_tb_size=%td\n",
+ tcg_ctx.code_gen_ptr - tcg_ctx.code_gen_buffer,
+ tcg_ctx.tb_ctx.nb_tbs, tcg_ctx.tb_ctx.nb_tbs > 0 ?
+ (tcg_ctx.code_gen_ptr - tcg_ctx.code_gen_buffer) /
+ tcg_ctx.tb_ctx.nb_tbs : 0);
+ }
if ((unsigned long)(tcg_ctx.code_gen_ptr - tcg_ctx.code_gen_buffer)
> tcg_ctx.code_gen_buffer_size) {
cpu_abort(cpu, "Internal error: code buffer overflow\n");
--
2.13.6
- [Qemu-devel] [PULL v2 02/20] tcg: fix corruption of code_time profiling counter upon tb_flush, (continued)
- [Qemu-devel] [PULL v2 02/20] tcg: fix corruption of code_time profiling counter upon tb_flush, Richard Henderson, 2017/10/10
- [Qemu-devel] [PULL v2 03/20] exec-all: fix typos in TranslationBlock's documentation, Richard Henderson, 2017/10/10
- [Qemu-devel] [PULL v2 05/20] cpu-exec: rename have_tb_lock to acquired_tb_lock in tb_find, Richard Henderson, 2017/10/10
- [Qemu-devel] [PULL v2 01/20] cputlb: bring back tlb_flush_count under !TLB_DEBUG, Richard Henderson, 2017/10/10
- [Qemu-devel] [PULL v2 04/20] translate-all: make have_tb_lock static, Richard Henderson, 2017/10/10
- [Qemu-devel] [PULL v2 06/20] tcg/i386: constify tcg_target_callee_save_regs, Richard Henderson, 2017/10/10
- [Qemu-devel] [PULL v2 07/20] tcg/mips: constify tcg_target_callee_save_regs, Richard Henderson, 2017/10/10
- [Qemu-devel] [PULL v2 13/20] translate-all: define and use DEBUG_TB_INVALIDATE_GATE, Richard Henderson, 2017/10/10
- [Qemu-devel] [PULL v2 10/20] exec-all: bring tb->invalid into tb->cflags, Richard Henderson, 2017/10/10
- [Qemu-devel] [PULL v2 09/20] tcg: consolidate TB lookups in tb_lookup__cpu_state, Richard Henderson, 2017/10/10
- [Qemu-devel] [PULL v2 11/20] translate-all: define and use DEBUG_TB_FLUSH_GATE,
Richard Henderson <=
- [Qemu-devel] [PULL v2 08/20] tcg: remove addr argument from lookup_tb_ptr, Richard Henderson, 2017/10/10
- [Qemu-devel] [PULL v2 14/20] translate-all: define and use DEBUG_TB_CHECK_GATE, Richard Henderson, 2017/10/10
- [Qemu-devel] [PULL v2 17/20] tcg: take .helpers out of TCGContext, Richard Henderson, 2017/10/10
- [Qemu-devel] [PULL v2 12/20] exec-all: introduce TB_PAGE_ADDR_FMT, Richard Henderson, 2017/10/10
- [Qemu-devel] [PULL v2 18/20] util: move qemu_real_host_page_size/mask to osdep.h, Richard Henderson, 2017/10/10
- [Qemu-devel] [PULL v2 16/20] tci: move tci_regs to tcg_qemu_tb_exec's stack, Richard Henderson, 2017/10/10
- [Qemu-devel] [PULL v2 20/20] tcg/mips: delete commented out extern keyword., Richard Henderson, 2017/10/10
- [Qemu-devel] [PULL v2 15/20] exec-all: extract tb->tc_* into a separate struct tc_tb, Richard Henderson, 2017/10/10
- [Qemu-devel] [PULL v2 19/20] tcg: define TCG_HIGHWATER, Richard Henderson, 2017/10/10
- Re: [Qemu-devel] [PULL v2 00/20] Queued TCG patches, no-reply, 2017/10/10