qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 00/27] vhost-user patches


From: Kamil Rytarowski
Subject: Re: [Qemu-devel] [PULL 00/27] vhost-user patches
Date: Tue, 10 Oct 2017 20:23:39 +0200
User-agent: Mozilla/5.0 (X11; NetBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0

On 10.10.2017 19:42, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
>> On 10 October 2017 at 18:10, Marc-André Lureau
>> <address@hidden> wrote:
>>> The following changes since commit
>>> 567d0a19c7998fa366598b83d5a6e5f0759d3ea9:
>>>
>>>   Merge remote-tracking branch
>>>   'remotes/ehabkost/tags/x86-and-machine-pull-request' into staging
>>>   (2017-10-10 13:25:46 +0100)
>>>
>>> are available in the Git repository at:
>>>
>>>   https://github.com/elmarco/qemu.git tags/vus-pull-request
>>>
>>> for you to fetch changes up to 25f1fe82c64c8c4922254d63195e1d9cffbb0507:
>>>
>>>   vhost-user-scsi: remove server_sock from VusDev (2017-10-10 19:06:06
>>>   +0200)
>>>
>>> ----------------------------------------------------------------
>>>
>>> ----------------------------------------------------------------
>>
>> Hi. I'm afraid this fails to build:
>>
>> On ppc host:
>>   CC      contrib/libvhost-user/libvhost-user.o
>> /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c: In function
>> ‘vu_set_vring_addr_exec’:
>> /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c:524:5: error:
>> format ‘%llx’ expects argument of type ‘long long unsigned int’, but
>> argument 3 has type ‘__u64’ [-Werror=format=]
>>      DPRINT("    desc_user_addr:   0x%016llx\n", vra->desc_user_addr);
>>      ^
>> /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c:525:5: error:
>> format ‘%llx’ expects argument of type ‘long long unsigned int’, but
>> argument 3 has type ‘__u64’ [-Werror=format=]
>>      DPRINT("    used_user_addr:   0x%016llx\n", vra->used_user_addr);
>>      ^
>> /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c:526:5: error:
>> format ‘%llx’ expects argument of type ‘long long unsigned int’, but
>> argument 3 has type ‘__u64’ [-Werror=format=]
>>      DPRINT("    avail_user_addr:  0x%016llx\n", vra->avail_user_addr);
>>      ^
>> /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c:527:5: error:
>> format ‘%llx’ expects argument of type ‘long long unsigned int’, but
>> argument 3 has type ‘__u64’ [-Werror=format=]
>>      DPRINT("    log_guest_addr:   0x%016llx\n", vra->log_guest_addr);
>>      ^
>>
>>
>> On NetBSD, OpenBSD, FreeBSD, OSX:
>>
>>   CC      contrib/libvhost-user/libvhost-user.o
>> /root/qemu/contrib/libvhost-user/libvhost-user.c:27:25: fatal error:
>> sys/eventfd.h: No such file or directory
>>  #include <sys/eventfd.h>
>>                          ^
>> compilation terminated.
>>
> 
> That was quick!
> 
> It looks like the solution is to remove libvhost-user.a from $(SUBDIR_RULES) 
> target. I have checked with 'make vm-build-freebsd'.
> 
> (the printf format errors are pre-existing - I think should be addressed in a 
> different series) 
> 
> 
> 

This interface is absent in all BSDs, it's available in SmartOS
(Illumos). The equivalent is kevent(2)/kqueue(2).

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]