Re: [Qemu-devel] [PATCH] oslib-posix: Fix compiler warning

[Richard Henderson]

On 10/09/2017 10:39 PM, Stefan Weil wrote:
> Am 09.10.2017 um 23:58 schrieb Richard Henderson:
>> On 10/07/2017 08:55 AM, Stefan Weil wrote:
>>> +        char *addr = memset_args->addr;
>>> +        uint64_t numpages = memset_args->numpages;
>>> +        uint64_t hpagesize = memset_args->hpagesize;
>>> +        unsigned i;
>>
>> Match numpages properly while you're at it?
>>
>>
>> r~
> 
> Do you mean using uint64_t for the loop variable i?

Yes.

> Sure. I only hesitated to do that because it is so huge.
> A 64 bit loop variable looks strange, and the loop would
> take some time if it really uses that range. :-)

Why would we use a 64-bit variable for numpages if we don't expect such a
value?  What I see, from spot review only, is an apparent bug -- the iterator
type does not match the bound type.


r~