[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/22] tcg: tb_lock removal
|
From: |
Emilio G. Cota |
|
Subject: |
Re: [Qemu-devel] [PATCH 00/22] tcg: tb_lock removal |
|
Date: |
Fri, 6 Oct 2017 13:08:57 -0400 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Oct 06, 2017 at 11:56:21 +0100, Alex Bennée wrote:
>
> Emilio G. Cota <address@hidden> writes:
>
> > On Mon, Aug 07, 2017 at 19:52:16 -0400, Emilio G. Cota wrote:
> >> This series applies on top of the "multiple TCG contexts" series, v4:
> >> https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg06769.html
> > (snip)
> >> Please review!
> >
> > Turns out this patchset breaks icount, even after fixing the patchset
> > it is based on (see [1]).
>
> Isn't icount only used in single-threaded mode though?
Yes, but it also hits some code paths that get executed very rarely
(or not at all) in !icount mode. And we still acquire locks in single-threaded
mode -- the breakage is most likely due to a missing page_unlock somewhere.
Cheers,
Emilio