qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 3/5] hmp-commands-info: Fix "info rocker-FOO" mis


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PULL 3/5] hmp-commands-info: Fix "info rocker-FOO" misspellings
Date: Thu, 5 Oct 2017 14:47:01 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 05/10/2017 12:51, Dr. David Alan Gilbert (git) wrote:
> From: Markus Armbruster <address@hidden>
> 
> Screwed up in commit da76ee7.

Let me introduce you to these two aliases:

        whatis = "show -s --pretty='tformat:%h (\"%s\", %cd)' --date=short"
        pwhatis = "show -s --pretty='tformat:%h, \"%s\", %cd' --date=short"

$ git whatis da76ee7
da76ee76f7 ("hmp-commands-info: move info_cmds content out of monitor.c", 
2015-09-16)

pwhatis is more appropriate if you are including the commit at the end
of a parenthetical remark, like

   ... (see commit message for 53ec73e, "block: Use bdrv_drain to
   replace uncessary bdrv_drain_all", 2015-07-07).

Paolo

> Signed-off-by: Markus Armbruster <address@hidden>
> Message-Id: <address@hidden>
> Reviewed-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---




reply via email to

[Prev in Thread] Current Thread [Next in Thread]