Re: [Qemu-devel] [PATCH] checkpatch: fix incompatibility with old perl

[Alex Williamson]

On Wed,  4 Oct 2017 18:44:20 +0300
Vladimir Sementsov-Ogievskiy <address@hidden> wrote:

> Do not use '/r' modifier which was introduced in perl 5.14.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---

Fixes: 3e5875afc0f ("checkpatch: check trace-events code style")
Tested-by: Alex Williamson <address@hidden>

Thanks

>  scripts/checkpatch.pl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 3c0a28e644..0c41f1212f 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1432,7 +1432,8 @@ sub process {
>                                       qr/%[-+ 
> *.0-9]*([hljztL]|ll|hh)?(x|X|"\s*PRI[xX][^"]*"?)/;
>  
>                               # don't consider groups splitted by [.:/ ], 
> like 2A.20:12ab
> -                             my $tmpline = $rawline =~ s/($hex[.:\/ 
> ])+$hex//gr;
> +                             my $tmpline = $rawline;
> +                             $tmpline =~ s/($hex[.:\/ ])+$hex//g;
>  
>                               if ($tmpline =~ /(?<!0x)$hex/) {
>                                       ERROR("Hex numbers must be prefixed 
> with '0x'\n" .