[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test |
Date: |
Wed, 4 Oct 2017 15:07:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 04.10.2017 14:46, Juan Quintela wrote:
> Thomas Huth <address@hidden> wrote:
>> On 04.10.2017 12:39, Juan Quintela wrote:
>>> Signed-off-by: Juan Quintela <address@hidden>
>
>>
>> Looks like a lot of this code is the same or very similar to the code in
>> postcopy-test.c ... would it make sense to factor-out that code there
>> into a separate file that could be used by both tests, so that we do not
>> have to maintain the code twice?
>
>
> I think I put that on the cover letter, my idea is to add the postcopy
> test here.
OK, then I think you should remove the duplicated functions from
postcopy-test.c in the same patch here, so that it is more obvious that
this is a code movement.
Thomas
PS: Please also add an entry to MAINTAINERS for the new files if feasible.
- [Qemu-devel] [PATCH 0/6] Add make check tests for Migration, Juan Quintela, 2017/10/04
- [Qemu-devel] [PATCH 2/6] tests: Add basic migration precopy tcp test, Juan Quintela, 2017/10/04
- [Qemu-devel] [PATCH 3/6] tests: Add precopy test using deprecated commands, Juan Quintela, 2017/10/04
- [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test, Juan Quintela, 2017/10/04
- Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test, Eric Blake, 2017/10/04
- Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test, Peter Xu, 2017/10/09
- Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test, Dr. David Alan Gilbert, 2017/10/16
- Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test, Peter Xu, 2017/10/18
- Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test, Juan Quintela, 2017/10/18
- Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test, Daniel P. Berrange, 2017/10/18
- Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test, Peter Xu, 2017/10/18
- Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test, Daniel P. Berrange, 2017/10/19
- Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test, Dr. David Alan Gilbert, 2017/10/19