[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 16/32] qapi: Factor out _make_implicit_wrapp
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [RFC PATCH 16/32] qapi: Factor out _make_implicit_wrapper_type() |
Date: |
Wed, 4 Oct 2017 14:00:16 +0200 |
On Mon, Oct 2, 2017 at 5:25 PM, Markus Armbruster <address@hidden> wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> scripts/qapi.py | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index 248d650858..4871eb7740 100644
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -1552,6 +1552,11 @@ class QAPISchema(object):
> members, None))
> return name
>
> + def _make_implicit_wrapper_type(self, typ, info):
> + return self._make_implicit_object_type(
> + typ, info, None, 'wrapper',
> + [self._make_member('data', typ, info)])
> +
> def _def_enum_type(self, expr, info, doc):
> name = expr['enum']
> data = expr['data']
> @@ -1588,8 +1593,7 @@ class QAPISchema(object):
> if isinstance(typ, list):
> assert len(typ) == 1
> typ = self._make_array_type(typ[0], info)
> - typ = self._make_implicit_object_type(
> - typ, info, None, 'wrapper', [self._make_member('data', typ,
> info)])
> + typ = self._make_implicit_wrapper_type(typ, info)
> return QAPISchemaObjectTypeVariant(case, typ)
>
> def _def_union_type(self, expr, info, doc):
> --
> 2.13.6
>
>
--
Marc-André Lureau
- [Qemu-devel] [RFC PATCH 00/32] Command line QAPIfication, Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 24/32] qapi-options: Generate help string, Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 18/32] docs/devel/qapi-code-gen.txt: Rewrite section on schema syntax, Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 16/32] qapi: Factor out _make_implicit_wrapper_type(), Markus Armbruster, 2017/10/02
- Re: [Qemu-devel] [RFC PATCH 16/32] qapi: Factor out _make_implicit_wrapper_type(),
Marc-André Lureau <=
- [Qemu-devel] [RFC PATCH 01/32] tests/qapi-schema: Improve coverage of '@', Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 04/32] qapi2texi: Fix for '@' not followed by \w character, Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 09/32] qapi: check_type() parameter allow_optional is now unused, drop, Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 13/32] qapi: Use argparse to open schema file, Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 06/32] qapi2texi: Drop | example markup, Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 29/32] qapi/options: QAPIfy --echr argument type, Markus Armbruster, 2017/10/02