[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 07/32] qapi: Drop superfluous allow_optional
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [RFC PATCH 07/32] qapi: Drop superfluous allow_optional=True |
Date: |
Wed, 4 Oct 2017 12:52:54 +0200 |
On Mon, Oct 2, 2017 at 5:25 PM, Markus Armbruster <address@hidden> wrote:
> check_command() passes allow_optional=True to check_type(). Useless
> unless you also pass allow_dict=True, which check_command() doesn't.
> Drop the superfluous argument.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> scripts/qapi.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index 43a54bf40f..248af89b0b 100644
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -695,7 +695,7 @@ def check_command(expr, info):
> returns_meta += ['built-in', 'alternate', 'enum']
> check_type(info, "'returns' for command '%s'" % name,
> expr.get('returns'), allow_array=True,
> - allow_optional=True, allow_metas=returns_meta)
> + allow_metas=returns_meta)
>
>
> def check_event(expr, info):
> --
> 2.13.6
>
>
--
Marc-André Lureau
- [Qemu-devel] [RFC PATCH 12/32] qapi: Use argparse to parse command line arguments, (continued)
- [Qemu-devel] [RFC PATCH 12/32] qapi: Use argparse to parse command line arguments, Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 17/32] qapi: Fix simple union lowering with multiple schemas, Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 15/32] tests/qapi-schema: Improve simple union coverage, Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 11/32] qapi: Drop the options to generate only .c or .h, Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 07/32] qapi: Drop superfluous allow_optional=True, Markus Armbruster, 2017/10/02
- Re: [Qemu-devel] [RFC PATCH 07/32] qapi: Drop superfluous allow_optional=True,
Marc-André Lureau <=
- [Qemu-devel] [RFC PATCH 03/32] qapi2texi: Fix for examples containing '@', Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 26/32] qapi2texi: Include command line options information, Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 27/32] os-posix: Drop misleading comment, Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 14/32] qapi: Rework generated code for built-in types, Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 28/32] vl: QAPIfy command line option definition, Markus Armbruster, 2017/10/02