[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/11] qapi: Stop rejecting #optional
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 02/11] qapi: Stop rejecting #optional |
Date: |
Wed, 4 Oct 2017 12:15:12 +0200 |
On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster <address@hidden> wrote:
> Commit 1d8bda1 got rid of #optional tags, and added a check to keep
> them from getting added back, to make sure patches then in flight
> don't add them back. It's been six months, time to drop that check.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> scripts/qapi.py | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index 62dc52ed6e..dc92bca620 100644
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -234,10 +234,6 @@ class QAPIDoc(object):
> raise QAPIParseError(self.parser,
> "'%s' not allowed in free-form
> documentation"
> % match.group(1))
> - # TODO Drop this once the dust has settled
> - if (isinstance(self.section, QAPIDoc.ArgSection)
> - and '#optional' in line):
> - raise QAPISemError(self.info, "Please drop the #optional tag")
> self.section.append(line)
>
> def connect_member(self, member):
> --
> 2.13.6
>
>
--
Marc-André Lureau
- [Qemu-devel] [PATCH 00/11] qapi: Cleanups around qapi2texi, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 04/11] qapi: Make cur_doc local to QAPISchemaParser.__init__(), Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 07/11] qapi: Unify representation of doc section without name, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 02/11] qapi: Stop rejecting #optional, Markus Armbruster, 2017/10/02
- Re: [Qemu-devel] [PATCH 02/11] qapi: Stop rejecting #optional,
Marc-André Lureau <=
- [Qemu-devel] [PATCH 03/11] qapi: Eliminate QAPISchemaParser.__init__()'s local fname, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 05/11] tests/qapi-schema/doc-bad-section: New, factored out of doc-good, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 06/11] qapi2texi: Clean up texi_sections(), Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 10/11] qapi: Rename QAPIDoc.parser, .section to ._parser, ._section, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 01/11] qapi-schema: Fix query-vm-generation-id's doc comment markup, Markus Armbruster, 2017/10/02