[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [Bug 1327608] Re: monitor socked path is cut a 105 characte
From: |
Daniel Berrange |
Subject: |
[Qemu-devel] [Bug 1327608] Re: monitor socked path is cut a 105 characters |
Date: |
Tue, 03 Oct 2017 14:36:55 -0000 |
There's actually two bugs here.
First QEMU was truncating the UNIX, but because it used 'snprintf', QEMU
truncated it at 107 characters and then added a trailing NUL, instead of
truncating at 108 characters and not having a NUL (which is perfectly
fine for AF_UNIX)
Second though if you look at the path socat is using, it has truncated
it at 104 characters. So even if QEMU had correctly truncated at 108
characters, socat would still have failed.
QEMU git now just returns an immediate if the path is too long rather
than truncating, so I think we can just close this.
** Changed in: qemu
Status: Incomplete => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1327608
Title:
monitor socked path is cut a 105 characters
Status in QEMU:
Fix Committed
Bug description:
Starting a VM like so:
/usr/bin/qemu-system-x86_64 -machine accel=kvm -monitor
unix:/srv/localfs/Samsung_SSD_840_PRO_Series_S1AXNSAF320206J/vg-virt
/lv-gentoosummerschool/gentoo-summerschool/gentoo-
summerschool.img.monitor,server,nowait -name gentoo-summerschool
-chardev
socket,id=monitor,path=/srv/localfs/Samsung_SSD_840_PRO_Series_S1AXNSAF320206J
/vg-virt/lv-gentoosummerschool/gentoo-
summerschool/monitor.sock,server,nowait -monitor chardev:monitor
-chardev
socket,id=serial0,path=/srv/localfs/Samsung_SSD_840_PRO_Series_S1AXNSAF320206J
/vg-virt/lv-gentoosummerschool/gentoo-
summerschool/console.sock,server,nowait -serial chardev:serial0
-enable-kvm -cpu kvm64 -smp 2 -netdev
tap,id=net0,script=/srv/localfs/Samsung_SSD_840_PRO_Series_S1AXNSAF320206J
/vg-virt/lv-gentoosummerschool/gentoo-summerschool/qemu-ifup.bash
-device e1000,netdev=net0,mac=00:00:00:00:00:02 -drive
id=disk,file=/srv/localfs/Samsung_SSD_840_PRO_Series_S1AXNSAF320206J
/vg-virt/lv-gentoosummerschool/gentoo-summerschool/gentoo-
summerschool.img,if=none -device ahci,id=ahci -device ide-
drive,drive=disk,bus=ahci.0 -m 2048 -vga qxl -spice
port=2002,addr=192.168.4.2,password=NO-thats-not-my-pwd -device
virtio-serial-pci -device
virtserialport,chardev=spicechannel0,name=com.redhat.spice.0 -chardev
spicevmc,id=spicechannel0,name=vdagent
The path:
unix:/srv/localfs/Samsung_SSD_840_PRO_Series_S1AXNSAF320206J/vg-virt
/lv-gentoosummerschool/gentoo-summerschool/gentoo-
summerschool.img.monitor
...is cut like so when I try to shutdown:
pink ~ # echo system_powerdown | socat -
UNIX-CONNECT:/srv/localfs/Samsung_SSD_840_PRO_Series_S1AXNSAF320206J/vg-virt/lv-gentoosummerschool/gentoo-summerschool/gentoo-summerschool.img.monitor
2014/06/08 06:39:01 socat[2344] E connect(3, AF=1
"/srv/localfs/Samsung_SSD_840_PRO_Series_S1AXNSAF320206J/vg-virt/lv-gentoosummerschool/gentoo-summerschoo",
110): No such file or directory
pink ~ #
It does work with a sorter path like:
pink ~ # echo system_powerdown | socat -
UNIX-CONNECT:'/srv/localfs/Samsung_SSD_840_PRO_Series_S1AXNSAF320206J/vg-virt/my.img.monitor'
QEMU 1.5.3 monitor - type 'help' for more information
(qemu) system_powerdown
(qemu) pink ~ #
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1327608/+subscriptions