[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/3] QAPI patches for 2017-10-02
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PULL 0/3] QAPI patches for 2017-10-02 |
Date: |
Mon, 2 Oct 2017 09:36:03 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/02/2017 06:42 AM, address@hidden wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Checking PATCH 2/3: watchdog.h: Drop local redefinition of actions enum...
> ERROR: braces {} are necessary for all arms of this statement
> #57: FILE: hw/watchdog/watchdog.c:86:
> + if (action < 0)
> [...]
Pre-existing problem, but would indeed be easy to fix up as part of this
series. I don't know if that means Markus should respin the pull request?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PULL 0/3] QAPI patches for 2017-10-02, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PULL 3/3] watchdog: Allow setting action on the fly, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PULL 2/3] watchdog.h: Drop local redefinition of actions enum, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PULL 1/3] qapi: Rename WatchdogExpirationAction enum, Markus Armbruster, 2017/10/02
- Re: [Qemu-devel] [PULL 0/3] QAPI patches for 2017-10-02, no-reply, 2017/10/02
- Re: [Qemu-devel] [PULL 0/3] QAPI patches for 2017-10-02,
Eric Blake <=
- Re: [Qemu-devel] [PULL 0/3] QAPI patches for 2017-10-02, Peter Maydell, 2017/10/03