[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/47] audio: Replace AUDIO_FUNC with __func_
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/47] audio: Replace AUDIO_FUNC with __func__ |
Date: |
Mon, 2 Oct 2017 09:08:07 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/29/2017 07:15 PM, Alistair Francis wrote:
> Apparently we don't use __MSC_VER as a compiler anymore and we always
> require a C99 compiler (which means we always have __func__) so we don't
> need a special AUDIO_FUNC macro. We can just repleace AUDIO_FUNC with
> __func__ instead.
>
> Checkpatch failures where manually fixed.
>
> Signed-off-by: Alistair Francis <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> ---
Module the typo fixes spotted by Thomas,
Reviewed-by: Eric Blake <address@hidden>
> +++ b/audio/audio.c
> @@ -424,12 +424,12 @@ static void audio_process_options (const char *prefix,
> const char qemu_prefix[] = "QEMU_";
> size_t preflen, optlen;
>
> - if (audio_bug (AUDIO_FUNC, !prefix)) {
> + if (audio_bug(__func__, !prefix)) {
I wonder if it would be nicer to have audio_bug() as a macro that
supplies __func__ automatically; but it's not enough of a concern to
prevent this patch from going in as-is.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v2 03/47] audio: Replace AUDIO_FUNC with __func__,
Eric Blake <=