[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Makefile: don't use LINKPROG for tests/migratio
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] Makefile: don't use LINKPROG for tests/migration/stress |
|
Date: |
Mon, 2 Oct 2017 12:19:54 +0100 |
On 2 October 2017 at 12:17, Daniel P. Berrange <address@hidden> wrote:
> On Mon, Oct 02, 2017 at 12:14:39PM +0100, Peter Maydell wrote:
>> Why does this executable need to define its own link rule anyway?
>> Ideally it should just use the standard rules.mak LINK function
>> like everything else. If it does need to do something weird
>> it should have a comment saying why it's weird...
>
> Primarily because we're static linking this binary so that it can be put
> into an initrd without needing any extra files added. It doesn't use any
> of the 3rd party libraries the rest of QEMU uses - ie no glib2 in particular.
Oh, are we committing our usual error of trying to build guest
binaries with the host toolchain?
thanks
-- PMM