Re: [Qemu-devel] [PATCH v6 2/6] docker: don't rely on submodules existing in the main checkout

[Fam Zheng]

On Thu, 09/28 10:52, Daniel P. Berrange wrote:
> On Thu, Sep 28, 2017 at 05:44:53PM +0800, Fam Zheng wrote:
> > On Thu, 09/28 09:44, Daniel P. Berrange wrote:
> > > When building the tarball to pass into the docker/vm test image,
> > > the code relies on the git submodules being checked out in the
> > > main checkout.
> > > 
> > > ie if the developer has not run 'git submodule update --init dtc'
> > > most (all?) of the docker tests will fail due to the missing dtc
> > > package in the test images.
> > 
> > Not all, fail only in envs/configs where libfdt devel doesn't exist.
> 
> I didn't test all of them but of the ~5 I did test all failed, so I
> just assumed none contain libftd-devel, since you have patchew
> manually check it out.

Patchew does it just because mingw needs it, this is not required for native
build:

$ git grep libfdt tests/docker
tests/docker/dockerfiles/centos6.docker:    libfdt-devel \
tests/docker/dockerfiles/centos7.docker:    libfdt-devel \
tests/docker/dockerfiles/fedora.docker:    glib2-devel pixman-devel zlib-devel 
SDL-devel libfdt-devel \
tests/docker/dockerfiles/min-glib.docker:RUN yum install -y libfdt-devel ccache
tests/docker/dockerfiles/ubuntu.docker:    libspice-protocol-dev libnss3-dev 
libfdt-dev \

Fam