[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 05/27] s390/tcg: turn INTERRUPT_EXT into a ma
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH v1 05/27] s390/tcg: turn INTERRUPT_EXT into a mask |
Date: |
Thu, 28 Sep 2017 21:08:49 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 26.09.2017 01:18, Richard Henderson wrote:
> On 09/18/2017 08:59 AM, David Hildenbrand wrote:
>> + } else if (env->pending_int | INTERRUPT_EXT_FLOATING) {
>
> Surely & here.
>
Yes, the code just worked because the next check is a
g_assert_not_reached() :)
Thanks!
> Otherwise,
>
> Reviewed-by: Richard Henderson <address@hidden>
>
>
> r~
>
--
Thanks,
David
- [Qemu-devel] [PATCH v1 04/27] s390x: introduce and use S390_MAX_CPUS, (continued)
- [Qemu-devel] [PATCH v1 05/27] s390/tcg: turn INTERRUPT_EXT into a mask, David Hildenbrand, 2017/09/18
- [Qemu-devel] [PATCH v1 06/27] s390x/tcg: injection of emergency signals and extarnal calls, David Hildenbrand, 2017/09/18
- [Qemu-devel] [PATCH v1 08/27] s390x/tcg: a CPU cannot switch state due to an interrupt, David Hildenbrand, 2017/09/18
- [Qemu-devel] [PATCH v1 07/27] s390x/tcg: STOPPED cpus can never wake up, David Hildenbrand, 2017/09/18
- [Qemu-devel] [PATCH v1 09/27] target/s390x: factor out handling of WAIT PSW into handle_wait(), David Hildenbrand, 2017/09/18