[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] hw/pci-bridge/pcie_pci_bridge: properly hand
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v2] hw/pci-bridge/pcie_pci_bridge: properly handle MSI unavailability case |
Date: |
Wed, 27 Sep 2017 18:40:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 25.09.2017 01:21, Aleksandr Bezzubikov wrote:
> QEMU with the pcie-pci-bridge device crashes if the guest board doesn't
> support MSI,
> e.g. 'qemu-system-ppc64 -M prep -device pcie-pci-bridge'.
> This is caused by wrong pcie-pci-bridge instantiation error handling. This
> patch fixes this issue
> by falling back to legacy INTx if MSI is not available.
> Also set the bridge's 'msi' property default value to 'auto' in order to
> trigger errors
> only when user explicitly set msi=on.
>
> v2:
> rewrite the commit message
>
> Reported-by: Eduardo Habkost <address@hidden>
> Signed-off-by: Aleksandr Bezzubikov <address@hidden>
> Reviewed-by: Marcel Apfelbaum <address@hidden>
> ---
> hw/pci-bridge/pcie_pci_bridge.c | 24 ++++++++++++++++++------
> 1 file changed, 18 insertions(+), 6 deletions(-)
This also fixes the issue that I've seen with qemu-system-mips64el today:
$ mips64el-softmmu/qemu-system-mips64el -M malta -nographic -S -device
pcie-pci-bridge -bios pc-bios/bios.bin
qemu-system-mips64el: memory.c:1699: memory_region_finalize:
Assertion `!mr->container' failed.
Aborted (core dumped)
So feel free to add:
Tested-by: Thomas Huth <address@hidden>