[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] basevm: Call logging.basicConfig()
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] basevm: Call logging.basicConfig() |
Date: |
Wed, 27 Sep 2017 21:35:44 +0800 |
User-agent: |
Mutt/1.9.0 (2017-09-02) |
On Wed, 09/27 10:03, Eduardo Habkost wrote:
> Just setting level=DEBUG when debug is enabled is not enough: we
> need to set up a log handler if we want debug messages generated
> using logging.getLogger(...).debug() to be printed.
>
> This was not a problem before because logging.debug() calls
> logging.basicConfig() implicitly, but it's safer to not rely on
> that.
>
> Cc: "Alex Bennée" <address@hidden>
> Cc: Fam Zheng <address@hidden>
> Cc: "Philippe Mathieu-Daudé" <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> tests/vm/basevm.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
> index 3c863bc237..686d88decf 100755
> --- a/tests/vm/basevm.py
> +++ b/tests/vm/basevm.py
> @@ -227,8 +227,8 @@ def main(vmcls):
> if not argv and not args.build_qemu and not args.build_image:
> print "Nothing to do?"
> return 1
> - if args.debug:
> - logging.getLogger().setLevel(logging.DEBUG)
> + logging.basicConfig(level=(logging.DEBUG if args.debug
> + else logging.WARN))
I find the " ? : " expression in C more readable than this in Python. :)
> vm = vmcls(debug=args.debug, vcpus=args.jobs)
> if args.build_image:
> if os.path.exists(args.image) and not args.force:
> --
> 2.13.5
>
Reviewed-by: Fam Zheng <address@hidden>
[Qemu-devel] [PATCH 5/5] scripts: Remove debug parameter from QEMUMachine, Eduardo Habkost, 2017/09/27