[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] scripts: Remove debug parameter from QEMUMa
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH 5/5] scripts: Remove debug parameter from QEMUMachine |
Date: |
Wed, 27 Sep 2017 14:22:24 +0100 |
User-agent: |
Mutt/1.9.0 (2017-09-02) |
On Wed, Sep 27, 2017 at 10:03:39AM -0300, Eduardo Habkost wrote:
> All scripts that use the QEMUMachine and QEMUQtestMachine classes
> (device-crash-test, tests/migration/*, iotests.py, basevm.py)
> already configure logging.
>
> The basicConfig() call inside QEMUMachine.__init__() is being
> kept just to make sure a script would still work if it didn't
> configure logging.
I don't find that compelling. IIUC, if we remove this basicConfig
they'll see a message that logging is not configured, which is a
suitable hint to fix the script to configure logging.
>
> # just in case logging wasn't configured by the main script:
> - logging.basicConfig(level=(logging.DEBUG if debug else logging.WARN))
> + logging.basicConfig()
So I'd just remove this line entirely
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH 3/5] basevm: Call logging.basicConfig(), (continued)