[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 08/24] iotests: Print full path of bad output if
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PULL 08/24] iotests: Print full path of bad output if mismatch |
Date: |
Tue, 26 Sep 2017 17:25:14 +0200 |
User-agent: |
Mutt/1.9.0 (2017-09-02) |
Am 26.09.2017 um 16:56 hat Eric Blake geschrieben:
> On 09/26/2017 09:21 AM, Kevin Wolf wrote:
> > From: Fam Zheng <address@hidden>
> >
> > So it is easier to copy paste the path.
> >
> > Signed-off-by: Fam Zheng <address@hidden>
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> > tests/qemu-iotests/check | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
> > index d504b6e455..4583a0c269 100755
> > --- a/tests/qemu-iotests/check
> > +++ b/tests/qemu-iotests/check
> > @@ -353,7 +353,7 @@ do
> > else
> > echo " - output mismatch (see $seq.out.bad)"
> > mv $tmp.out $seq.out.bad
> > - $diff -w "$reference" $seq.out.bad
> > + $diff -w "$reference" $(realpath $seq.out.bad)
>
> This missed my review comments about being unsafe if $PWD contains spaces:
> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg04241.html
Sorry for missing this. Please send a follow-up patch to fix it.
Kevin
signature.asc
Description: PGP signature
- [Qemu-devel] [PULL 00/24] Block layer patches, Kevin Wolf, 2017/09/26
- [Qemu-devel] [PULL 01/24] qemu-iotests: Add missing -machine accel=qtest, Kevin Wolf, 2017/09/26
- [Qemu-devel] [PULL 02/24] qemu-img: Clarify about relative backing file options, Kevin Wolf, 2017/09/26
- [Qemu-devel] [PULL 06/24] iotests: use -ccw on s390x for 051, Kevin Wolf, 2017/09/26
- [Qemu-devel] [PULL 08/24] iotests: Print full path of bad output if mismatch, Kevin Wolf, 2017/09/26
- [Qemu-devel] [PULL 05/24] iotests: use -ccw on s390x for 040, 139, and 182, Kevin Wolf, 2017/09/26
- [Qemu-devel] [PULL 03/24] file-posix: Clear out first sector in hdev_create, Kevin Wolf, 2017/09/26
- [Qemu-devel] [PULL 10/24] block/throttle-groups.c: allocate RestartData on the heap, Kevin Wolf, 2017/09/26
- [Qemu-devel] [PULL 13/24] block: Add reopen_queue to bdrv_child_perm(), Kevin Wolf, 2017/09/26
- [Qemu-devel] [PULL 12/24] qemu-io: Drop write permissions before read-only reopen, Kevin Wolf, 2017/09/26
- [Qemu-devel] [PULL 09/24] throttle: Assert that bkt->max is valid in throttle_compute_wait(), Kevin Wolf, 2017/09/26
- [Qemu-devel] [PULL 07/24] iotests: use virtio aliases for 067, Kevin Wolf, 2017/09/26
- [Qemu-devel] [PULL 17/24] block: Fix permissions after bdrv_reopen(), Kevin Wolf, 2017/09/26
- [Qemu-devel] [PULL 18/24] qemu-iotests: Test change-backing-file command, Kevin Wolf, 2017/09/26
- [Qemu-devel] [PULL 04/24] docs: add qemu-block-drivers(7) man page, Kevin Wolf, 2017/09/26