Re: [Qemu-devel] [PATCH v3 1/4] qom: provide root container for internal objs

[Peter Xu]

On Tue, Sep 26, 2017 at 12:58:24PM +0800, Fam Zheng wrote:
> On Tue, 09/26 12:52, Peter Xu wrote:
> > We have object_get_objects_root() to keep user created objects, however
> > no place for objects that will be used internally.  Create such a
> > container for internal objects.
> > 
> > CC: Andreas Färber <address@hidden>
> > CC: Markus Armbruster <address@hidden>
> > CC: Paolo Bonzini <address@hidden>
> > Suggested-by: Daniel P. Berrange <address@hidden>
> > Signed-off-by: Peter Xu <address@hidden>
> > ---
> >  include/qom/object.h | 10 ++++++++++
> >  qom/object.c         | 11 +++++++++++
> >  2 files changed, 21 insertions(+)
> > 
> > diff --git a/include/qom/object.h b/include/qom/object.h
> > index f3e5cff..f567052 100644
> > --- a/include/qom/object.h
> > +++ b/include/qom/object.h
> > @@ -1214,6 +1214,16 @@ Object *object_get_root(void);
> >  Object *object_get_objects_root(void);
> >  
> >  /**
> > + * object_get_internal_root:
> > + *
> > + * Get the container object that holds internally used object
> > + * instances. This is the object at path "/internal-objects"
> 
> Does this comment need update?

Definitely. :)

-- 
Peter Xu