[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 10/27] s390x/kvm: pass ipb directly into hand
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v1 10/27] s390x/kvm: pass ipb directly into handle_sigp() |
Date: |
Mon, 25 Sep 2017 12:27:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 18.09.2017 17:59, David Hildenbrand wrote:
> No need to pass kvm_run.
>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> target/s390x/kvm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
> index 14f864697d..da3f7e9895 100644
> --- a/target/s390x/kvm.c
> +++ b/target/s390x/kvm.c
> @@ -1852,7 +1852,7 @@ static int sigp_set_architecture(S390CPU *cpu, uint32_t
> param,
> return SIGP_CC_STATUS_STORED;
> }
>
> -static int handle_sigp(S390CPU *cpu, struct kvm_run *run, uint8_t ipa1)
> +static int handle_sigp(S390CPU *cpu, uint32_t ipb, uint8_t ipa1)
Maybe order the parameters alphabetically now? I.e. first ipa, then ipb?
Anyway, feel free to add my:
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH v1 06/27] s390x/tcg: injection of emergency signals and extarnal calls, (continued)
- [Qemu-devel] [PATCH v1 06/27] s390x/tcg: injection of emergency signals and extarnal calls, David Hildenbrand, 2017/09/18
- [Qemu-devel] [PATCH v1 08/27] s390x/tcg: a CPU cannot switch state due to an interrupt, David Hildenbrand, 2017/09/18
- [Qemu-devel] [PATCH v1 07/27] s390x/tcg: STOPPED cpus can never wake up, David Hildenbrand, 2017/09/18
- [Qemu-devel] [PATCH v1 09/27] target/s390x: factor out handling of WAIT PSW into handle_wait(), David Hildenbrand, 2017/09/18
- [Qemu-devel] [PATCH v1 10/27] s390x/kvm: pass ipb directly into handle_sigp(), David Hildenbrand, 2017/09/18
- [Qemu-devel] [PATCH v1 11/27] s390x/kvm: generalize SIGP stop and restart interrupt injection, David Hildenbrand, 2017/09/18
- [Qemu-devel] [PATCH v1 12/27] s390x/kvm: factor out storing of CPU status, David Hildenbrand, 2017/09/18
- [Qemu-devel] [PATCH v1 15/27] s390x/kvm: drop two debug prints, David Hildenbrand, 2017/09/18
- [Qemu-devel] [PATCH v1 13/27] target/s390x: proper cpu->be convertion in s390_store_status(), David Hildenbrand, 2017/09/18
- [Qemu-devel] [PATCH v1 14/27] s390x/kvm: factor out storing of adtl CPU status, David Hildenbrand, 2017/09/18