[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] slirp: Fix intermittent send queue hangs on
From: |
Samuel Thibault |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] slirp: Fix intermittent send queue hangs on a socket |
Date: |
Sun, 24 Sep 2017 19:53:14 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
Hello,
Kevin Cernekee, on mer. 20 sept. 2017 13:42:04 -0700, wrote:
> if_output() originally sent one mbuf per call and used the slirp->next_m
> variable to keep track of where it left off. But nowadays it tries to
> send all of the mbufs from the fastq, and one mbuf from each session on
> the batchq. The next_m variable is both redundant and harmful: there is
> a case[0] involving delayed packets in which next_m ends up pointing
> to &slirp->if_batchq when an active session still exists, and this
> blocks all traffic for that session until qemu is restarted.
That also makes things simpler, I applied it to my tree, thanks!
Samuel