[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 5/6] linux-user: fix 64bit versions of sparc and m
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [RFC 5/6] linux-user: fix 64bit versions of sparc and mips |
Date: |
Fri, 22 Sep 2017 19:01:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
Le 22/09/2017 à 16:02, Carlo Marcelo Arenas Belón a écrit :
> Signed-off-by: Carlo Marcelo Arenas Belón <address@hidden>
> ---
> linux-user/mips64/sockbits.h | 1 +
> linux-user/socket.h | 4 ++--
> linux-user/sparc64/sockbits.h | 1 +
Who includes the two new files?
Moreover TARGET_MIPS/TARGET_SPARC (base arch) are always defined when
TARGET_MIPS64/TARGET_SPARC64 (target arch) are defined.
So I think this patch is useless.
Thanks,
Laurent
> 3 files changed, 4 insertions(+), 2 deletions(-)
> create mode 100644 linux-user/mips64/sockbits.h
> create mode 100644 linux-user/sparc64/sockbits.h
>
> diff --git a/linux-user/mips64/sockbits.h b/linux-user/mips64/sockbits.h
> new file mode 100644
> index 0000000000..e6b6d31ac9
> --- /dev/null
> +++ b/linux-user/mips64/sockbits.h
> @@ -0,0 +1 @@
> +#include "../mips/sockbits.h"
> diff --git a/linux-user/socket.h b/linux-user/socket.h
> index dfa692286b..6fd486c6b1 100644
> --- a/linux-user/socket.h
> +++ b/linux-user/socket.h
> @@ -1,10 +1,10 @@
> -#if defined(TARGET_MIPS)
> +#if defined(TARGET_MIPS) || defined(TARGET_MIPS64)
> #include "mips/sockbits.h"
> #elif defined(TARGET_ALPHA)
> #include "alpha/sockbits.h"
> #elif defined(TARGET_HPPA)
> #include "hppa/sockbits.h"
> -#elif defined(TARGET_SPARC)
> +#elif defined(TARGET_SPARC) || defined(TARGET_SPARC64)
> #include "sparc/sockbits.h"
> #else
>
> diff --git a/linux-user/sparc64/sockbits.h b/linux-user/sparc64/sockbits.h
> new file mode 100644
> index 0000000000..658899e4d3
> --- /dev/null
> +++ b/linux-user/sparc64/sockbits.h
> @@ -0,0 +1 @@
> +#include "../sparc/sockbits.h"
>
- [Qemu-devel] [RFC 0/6] linux-user: refactor socket.h into architecture specific sockbits, Carlo Marcelo Arenas Belón, 2017/09/22
- [Qemu-devel] [RFC 2/6] linux-user: refactor socket.h for alpha, Carlo Marcelo Arenas Belón, 2017/09/22
- [Qemu-devel] [RFC 1/6] linux-user: update hppa sockbits, Carlo Marcelo Arenas Belón, 2017/09/22
- [Qemu-devel] [RFC 5/6] linux-user: fix 64bit versions of sparc and mips, Carlo Marcelo Arenas Belón, 2017/09/22
- Re: [Qemu-devel] [RFC 5/6] linux-user: fix 64bit versions of sparc and mips,
Laurent Vivier <=
- [Qemu-devel] [RFC 3/6] linux-user: refactor socket.h for mips, Carlo Marcelo Arenas Belón, 2017/09/22
- [Qemu-devel] [RFC 4/6] linux-user: refactor socket.h for sparc, Carlo Marcelo Arenas Belón, 2017/09/22
- [Qemu-devel] [RFC 6/6] linux-user: update default socket.h, Carlo Marcelo Arenas Belón, 2017/09/22