Re: [Qemu-devel] [RFC PATCH] vl.c: add is_system_on_chip flag to force board default cpu

[Alistair Francis]

On Tue, Sep 19, 2017 at 2:03 AM, Peter Maydell <address@hidden> wrote:
> On 18 September 2017 at 22:57, Philippe Mathieu-Daudé <address@hidden> wrote:
>> add a property to restrict the CPU for SoCs once on machine creation and 
>> avoid
>> duplicate code in each board.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>> Based-on: address@hidden
>>
>>  include/hw/boards.h |  3 +++
>>  vl.c                | 11 +++++++++++
>>  2 files changed, 14 insertions(+)
>>
>> diff --git a/include/hw/boards.h b/include/hw/boards.h
>> index 6b67adaef6..20dc0a0ab9 100644
>> --- a/include/hw/boards.h
>> +++ b/include/hw/boards.h
>> @@ -129,6 +129,8 @@ typedef struct {
>>   *    specifies default CPU_TYPE, which will be used for parsing target
>>   *    specific features and for creating CPUs if CPU name wasn't provided
>>   *    explicitly at CLI
>> + * @is_system_on_chip:
>> + *    If true, board does not support other CPUs than default_cpu_type.
>
> Being an SoC isn't the only reason a board might only support one
> CPU type (perhaps it just never existed with other than a single
> CPU soldered into it), so maybe a different name?

I don't think this makes a lot of sense. There are some SoCs that are
basically the same besides the CPU. I think a list of possible CPUs
makes more sense for machines. That way the list can be used for every
machine and not just machines with a single CPU. If your SoC only
supports one CPU then you only describe one, but if you want others
you can list others.

Thanks,
Alistair

>
> thanks
> -- PMM
>