Re: [Qemu-devel] [PATCH qemu v3 02/13] exec: Explicitely export target AS from address_space_translate_internal

[Alexey Kardashevskiy]

On 19/09/17 00:28, Eric Blake wrote:
> On 09/18/2017 05:16 AM, Alexey Kardashevskiy wrote:
> 
> Subject line: s/Explicitely/Explicitly/
> 
>> This is not so mechanical change in order to move to shared FlatViews
>> so make it a separate patch.
> 
> Hard to understand; it's unclear whether this is the mechanical addition
> of a parameter before the next patch does shared FlatViews, or whether
> the next patch is mechanical by virtue of this patch doing the
> non-mechanical changes.  Maybe:
> 
> Mechanical change to add a parameter to make it easier for the next
> patch to share FlatViews.

I was told in this list that "mechanical" is when simple 's/lalala/mememe/'
does the job, when it is bigger than this - then it is "this should not
cause any behavioural change" :) I'll add such note where applicable.

tbh only 1/13, 11/13 and 13/13 do cause a change in behaviour, others do not.

> 
>> The first argument of
>> address_space_do_translate() will become a FlatView, however since
>> address_space_get_iotlb_entry() still wants AS, hence this change.
>>
>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>> ---
>>  exec.c | 11 +++++++----
>>  1 file changed, 7 insertions(+), 4 deletions(-)
>>


-- 
Alexey

signature.asc
Description: OpenPGP digital signature