[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] xen_disk: avoid use of g_malloc0_n()
|
From: |
Anthony PERARD |
|
Subject: |
Re: [Qemu-devel] [PATCH] xen_disk: avoid use of g_malloc0_n() |
|
Date: |
Thu, 14 Sep 2017 17:23:43 +0100 |
|
User-agent: |
Mutt/1.9.0 (2017-09-02) |
On Tue, Sep 12, 2017 at 08:24:21AM -0600, Jan Beulich wrote:
> Prefer g_new() / g_new0() to be farther backwards compatible with older
> glib versions. As there's no point in zeroing the allocation here (the
> loop right afterwards fully initializes the memory), use the former.
>
> Signed-off-by: Jan Beulich <address@hidden>
Acked-by: Anthony PERARD <address@hidden>
> --- a/hw/block/xen_disk.c
> +++ b/hw/block/xen_disk.c
> @@ -1232,7 +1232,7 @@ static int blk_connect(struct XenDevice
> return -1;
> }
>
> - domids = g_malloc0_n(blkdev->nr_ring_ref, sizeof(uint32_t));
> + domids = g_new(uint32_t, blkdev->nr_ring_ref);
> for (i = 0; i < blkdev->nr_ring_ref; i++) {
> domids[i] = blkdev->xendev.dom;
> }
>
>
>
>
--
Anthony PERARD