[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] Add --firmwarepath to configure
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] Add --firmwarepath to configure |
Date: |
Thu, 14 Sep 2017 13:37:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 14/09/2017 10:36, Gerd Hoffmann wrote:
> Hi,
>
>>> + --firmwarepath=PATH search PATH for firmware files
>>
>> Maybe --firmwaredir or --with-firmwaredir (because firmwaredir is not
>> one of the "standard" directories)?
>
> I've intentionally named this "path" because it can actually have
> multiple directories.
>
> Or do you mean something else? If so --verbose please.
No, you're right.
Paolo
>>> + /* add configured firmware directories */
>>> + dirs = g_strsplit(CONFIG_QEMU_FIRMWAREPATH, ":", 0);
>>
>> Windows probably wants to use ; here, so you can use
>> G_SEARCHPATH_SEPARATOR_S instead of ":".
>
> Ah, cool, didn't know this exists. Fixing ...
>
> cheers,
> Gerd
>