[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] Add --firmwarepath to configure
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] Add --firmwarepath to configure |
Date: |
Thu, 14 Sep 2017 10:36:45 +0200 |
Hi,
> > + --firmwarepath=PATH search PATH for firmware files
>
> Maybe --firmwaredir or --with-firmwaredir (because firmwaredir is not
> one of the "standard" directories)?
I've intentionally named this "path" because it can actually have
multiple directories.
Or do you mean something else? If so --verbose please.
> > + /* add configured firmware directories */
> > + dirs = g_strsplit(CONFIG_QEMU_FIRMWAREPATH, ":", 0);
>
> Windows probably wants to use ; here, so you can use
> G_SEARCHPATH_SEPARATOR_S instead of ":".
Ah, cool, didn't know this exists. Fixing ...
cheers,
Gerd