Re: [Qemu-devel] [PATCH] mps2-an511: Fix wiring of UART overflow interrupt lines

[Alistair Francis]

On Tue, Sep 12, 2017 at 9:13 AM, Peter Maydell <address@hidden> wrote:
> Fix an error that meant we were wiring every UART's overflow
> interrupts into the same inputs 0 and 1 of the OR gate,
> rather than giving each its own input.
>
> Cc: address@hidden
> Signed-off-by: Peter Maydell <address@hidden>

Reviewed-by: Alistair Francis <address@hidden>

Thanks,
Alistair

> ---
>  hw/arm/mps2.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/mps2.c b/hw/arm/mps2.c
> index abb0ab6..769cff8 100644
> --- a/hw/arm/mps2.c
> +++ b/hw/arm/mps2.c
> @@ -287,8 +287,8 @@ static void mps2_common_init(MachineState *machine)
>              cmsdk_apb_uart_create(uartbase[i],
>                                    qdev_get_gpio_in(txrx_orgate_dev, 0),
>                                    qdev_get_gpio_in(txrx_orgate_dev, 1),
> -                                  qdev_get_gpio_in(orgate_dev, 0),
> -                                  qdev_get_gpio_in(orgate_dev, 1),
> +                                  qdev_get_gpio_in(orgate_dev, i * 2),
> +                                  qdev_get_gpio_in(orgate_dev, i * 2 + 1),
>                                    NULL,
>                                    uartchr, SYSCLK_FRQ);
>          }
> --
> 2.7.4
>
>