[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/12] qemu-iotests: disintegrate more parts of
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 07/12] qemu-iotests: disintegrate more parts of common.config |
|
Date: |
Tue, 12 Sep 2017 14:31:39 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 12/09/2017 12:40, Kevin Wolf wrote:
> Am 09.08.2017 um 23:55 hat Paolo Bonzini geschrieben:
>> Split "check" parts from tests part.
>>
>> For the directory setup, the actual computation of directories goes
>> in "check", while the sanity checks go in the tests.
>>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>
> Same comment as for patch 1, we may want to keep this working.
Can you explain what is the use case? For local symlinks I (sort of)
understand it, but not here. This as far as I understand is code that
never runs.
My preferred alternatives would be one of these:
- add a patch 13 that restores the local symlink feature on top of the
cleaned up code.
- later, rewrite "check" in Python now that it is clear what code is
part of it and what code is part of the tests.
or:
- leave local symlinks broken
- when "check" is rewritten in Python, add a configuration mechanism
based on .ini file syntax that replaces the local symlinks.
What do you think?
Paolo