Re: [Qemu-devel] [PATCH v4 09/20] instrument: Add basic control interface

[Lluís Vilanova]

Emilio G Cota writes:

> On Wed, Sep 06, 2017 at 20:59:02 +0300, Lluís Vilanova wrote:
>> Signed-off-by: Lluís Vilanova <address@hidden>
>> ---
>> Makefile                           |    5 +++
>> configure                          |    1 +
>> instrument/Makefile.objs           |    2 +
>> instrument/control.c               |   28 +++++++++++++++++
>> instrument/control.h               |   44 +++++++++++++++++++++++++++
>> instrument/control.inc.h           |   25 ++++++++++++++++
>> instrument/error.h                 |   28 +++++++++++++++++
>> instrument/events.h                |   37 +++++++++++++++++++++++
>> instrument/events.inc.h            |   11 +++++++

> Am I the only one who finds this control vs. events division confusing?

Control is only for controlling instrumentation, and the header is used mainly
inside the instrumentation directory. Wheread the events header is later going
to be included in every file that needs to trigger an instrumentation event.

> Also, do we need all these many files, even for the public API?

The only other header, error.h, is later used in many other files.


> And why the .inc's?

To keep tidy headers with documentation, and the implementation details stashed
away on a separate file (like in the case of trace/).


> Thanks,
>               E.


Cheers,
  Lluis