[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/3] Improve websock response / error handlin
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/3] Improve websock response / error handling |
Date: |
Fri, 8 Sep 2017 15:32:50 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Fri, Sep 08, 2017 at 07:28:30AM -0700, address@hidden wrote:
> /tmp/qemu-test/src/io/channel-websock.c: In function
> 'qio_channel_websock_date_str':
> /tmp/qemu-test/src/io/channel-websock.c:178:14: error: passing argument 1 of
> 'gmtime_r' from incompatible pointer type [-Werror=incompatible-pointer-types]
> gmtime_r(&tv.tv_sec, &tm);
> ^
> In file included from /tmp/qemu-test/src/include/qemu/osdep.h:76:0,
> from /tmp/qemu-test/src/io/channel-websock.c:21:
> /usr/x86_64-w64-mingw32/sys-root/mingw/include/time.h:272:34: note: expected
> 'const time_t * {aka const long long int *}' but argument is of type 'long
> int *'
> __forceinline struct tm *__cdecl gmtime_r(const time_t *_Time, struct tm
> *_Tm) {
> ^~~~~~~~
> cc1: all warnings being treated as errors
Ok that's interesting - Linux documents 'struct timeval' as containing
time_t type, but Mingw uses a plain 'long'. So much for standards :-(
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|