[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 19/19] s390x: get rid of cpu_s390x_create()
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v2 19/19] s390x: get rid of cpu_s390x_create() |
Date: |
Thu, 7 Sep 2017 19:11:59 +0200 |
On Mon, 4 Sep 2017 17:43:16 +0200
David Hildenbrand <address@hidden> wrote:
> Now that there is only one user of cpu_s390x_create() left, make cpu
> creation looks like on x86.
> - Perform the model/properties split and checks in s390_init_cpus()
> - Parse features only once without having to remember if already parsed
> - Pass only the typename to s390x_new_cpu()
> - Use the typename of an existing CPU for hotplug via cpu-add
>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> hw/s390x/s390-virtio-ccw.c | 29 +++++++++++++++++++++++++++--
> target/s390x/cpu.h | 2 +-
> target/s390x/helper.c | 45 ++-------------------------------------------
> target/s390x/internal.h | 1 -
> 4 files changed, 30 insertions(+), 47 deletions(-)
LGTM
- [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via device_del cannot work, (continued)
Re: [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via device_del cannot work, Matthew Rosato, 2017/09/06
[Qemu-devel] [PATCH v2 18/19] s390x: implement query-hotpluggable-cpus, David Hildenbrand, 2017/09/04
[Qemu-devel] [PATCH v2 19/19] s390x: get rid of cpu_s390x_create(), David Hildenbrand, 2017/09/04
- Re: [Qemu-devel] [PATCH v2 19/19] s390x: get rid of cpu_s390x_create(),
Cornelia Huck <=
Re: [Qemu-devel] [PATCH v2 00/19] s390x cleanups and CPU hotplug via device_add, Christian Borntraeger, 2017/09/05