[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2 v3] xenfb: Use Input Handlers directly
From: |
Anthony PERARD |
Subject: |
Re: [Qemu-devel] [PATCH 1/2 v3] xenfb: Use Input Handlers directly |
Date: |
Thu, 7 Sep 2017 15:56:18 +0100 |
User-agent: |
Mutt/1.9.0 (2017-09-02) |
On Mon, Aug 21, 2017 at 04:12:27PM -0700, Stefano Stabellini wrote:
> Anthony,
>
> The code looks good. I tested this patch with Linux guests and seems to
> work OK, can you also confirm?
I've tested with Linux as well, an HVM guess, I did not spot any issue.
But, the code compiles with warnings...
In file included from
/root/build/qemu/include/standard-headers/linux/input.h:16:0,
from hw/display/xenfb.c:41:
/root/build/qemu/include/standard-headers/linux/input-event-codes.h:88:0:
error: "KEY_BACKSPACE" redefined [-Werror]
#define KEY_BACKSPACE 14
In file included from /root/build/qemu/include/ui/console.h:342:0,
from hw/display/xenfb.c:31:
/usr/include/curses.h:1494:0: note: this is the location of the previous
definition
#define KEY_BACKSPACE 0407 /* backspace key */
In file included from
/root/build/qemu/include/standard-headers/linux/input.h:16:0,
from hw/display/xenfb.c:41:
/root/build/qemu/include/standard-headers/linux/input-event-codes.h:102:0:
error: "KEY_ENTER" redefined [-Werror]
#define KEY_ENTER 28
In file included from /root/build/qemu/include/ui/console.h:342:0,
from hw/display/xenfb.c:31:
/usr/include/curses.h:1512:0: note: this is the location of the previous
definition
#define KEY_ENTER 0527 /* enter/send key */
In file included from
/root/build/qemu/include/standard-headers/linux/input.h:16:0,
from hw/display/xenfb.c:41:
/root/build/qemu/include/standard-headers/linux/input-event-codes.h:107:0:
error: "KEY_F" redefined [-Werror]
#define KEY_F 33
In file included from /root/build/qemu/include/ui/console.h:342:0,
from hw/display/xenfb.c:31:
/usr/include/curses.h:1496:0: note: this is the location of the previous
definition
#define KEY_F(n) (KEY_F0+(n)) /* Value of function key n */
[...]
And a lot more...
--
Anthony PERARD
- Re: [Qemu-devel] [PATCH 1/2 v3] xenfb: Use Input Handlers directly,
Anthony PERARD <=