Re: [Qemu-devel] [PULL 0/5] NBD patches for 2017-09-06

[Daniel P. Berrange]

On Thu, Sep 07, 2017 at 08:48:15AM -0500, Eric Blake wrote:
> On 09/07/2017 07:26 AM, Peter Maydell wrote:
> > On 6 September 2017 at 16:21, Eric Blake <address@hidden> wrote:
> >> The following changes since commit 
> >> b07d1c2f5607489d4d4a6a65ce36a3e896ac065e:
> >>
> >>   Revert "kvm: use DIV_ROUND_UP" (2017-09-05 18:55:40 +0100)
> >>
> >> are available in the git repository at:
> >>
> >>   git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2017-09-06
> >>
> >> for you to fetch changes up to 030fa7f6f950f5c8963f1dee8e6bb7387ed86a99:
> >>
> >>   nbd: Use new qio_channel_*_all() functions (2017-09-06 10:11:54 -0500)
> >>
> 
> > I get an error in test-aio-multithread (clang, linux, x86-64):
> >   GTESTER tests/test-aio-multithread
> > **
> > ERROR:/home/petmay01/linaro/qemu-for-merges/tests/test-aio-multithread.c:368:test_multi_fair_mutex:
> > assertion failed (counter == atomic_counter): (532693 == 532694)
> > GTester: last random seed: R02Sa68ef1eb4822359eb869642ff26180df
> 
> I wonder if that is a rare but pre-existing bug, as I don't see any use
> of qio_channel in test-aio-multithread, and therefore no obvious way
> that this series would be the cause of the intermittent failure.

Agreed. Even if there was use of QIOChannel, there is certainly no use
of the qio_channel_read|write_all functions that are being changed
in this series, since they've only just been added to QEMU and are only
used in the test suite and your final NBD patch here. So I think this
must be a pre-existing race condition.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|