[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 26/29] fw_cfg-test: Drop dependence on global
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 26/29] fw_cfg-test: Drop dependence on global_qtest |
Date: |
Wed, 6 Sep 2017 16:45:53 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/05/2017 06:05 AM, Thomas Huth wrote:
> On 01.09.2017 20:03, Eric Blake wrote:
>> As a general rule, we prefer avoiding implicit global state
>> because it makes code harder to safely copy and paste without
>> thinking about the global state. It turns out that with the
>> recent changes to libqos, fw_cfg-test was not even using
>> global_qtest any more. Avoid a pointless strdup while at it.
>>
>> Signed-off-by: Eric Blake <address@hidden>
>> ---
>> tests/fw_cfg-test.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>>
>
> Why don't you merge this with patch 14/29?
Sure.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v6 24/29] bios-tables-test: Drop dependence on global_qtest, (continued)
- [Qemu-devel] [PATCH v6 27/29] libqtest: Make qtest_init() accept format string, Eric Blake, 2017/09/01
- [Qemu-devel] [PATCH v6 26/29] fw_cfg-test: Drop dependence on global_qtest, Eric Blake, 2017/09/01
- [Qemu-devel] [PATCH v6 28/29] libqtest: Remove qtest_start() and qtest_end() shortcuts, Eric Blake, 2017/09/01
- [Qemu-devel] [PATCH v6 29/29] libqtest: Rename qtest_init() to qtest_start(), Eric Blake, 2017/09/01
- Re: [Qemu-devel] [PATCH v6 00/29] Preliminary libqtest cleanups, no-reply, 2017/09/01