[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 8/8] migration: dump str in migrate_set_state trace
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PULL 8/8] migration: dump str in migrate_set_state trace |
Date: |
Wed, 6 Sep 2017 19:41:33 +0100 |
From: Peter Xu <address@hidden>
Strings are more readable for debugging.
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Fixed up merge with 977c73
---
migration/migration.c | 3 ++-
migration/trace-events | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 9838ccc885..959e8ec88e 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -913,8 +913,9 @@ void qmp_migrate_start_postcopy(Error **errp)
void migrate_set_state(int *state, int old_state, int new_state)
{
+ assert(new_state < MIGRATION_STATUS__MAX);
if (atomic_cmpxchg(state, old_state, new_state) == old_state) {
- trace_migrate_set_state(new_state);
+ trace_migrate_set_state(MigrationStatus_str(new_state));
migrate_generate_event(new_state);
}
}
diff --git a/migration/trace-events b/migration/trace-events
index 7a3b5144ff..d2910a6e7b 100644
--- a/migration/trace-events
+++ b/migration/trace-events
@@ -80,7 +80,7 @@ ram_save_queue_pages(const char *rbname, size_t start, size_t
len) "%s: start: 0
# migration/migration.c
await_return_path_close_on_source_close(void) ""
await_return_path_close_on_source_joining(void) ""
-migrate_set_state(int new_state) "new state %d"
+migrate_set_state(const char *new_state) "new state %s"
migrate_fd_cleanup(void) ""
migrate_fd_error(const char *error_desc) "error=%s"
migrate_fd_cancel(void) ""
--
2.13.5
- [Qemu-devel] [PULL 0/8] migration queue, Dr. David Alan Gilbert (git), 2017/09/06
- [Qemu-devel] [PULL 1/8] migration: Report when bdrv_inactivate_all fails, Dr. David Alan Gilbert (git), 2017/09/06
- [Qemu-devel] [PULL 3/8] host-utils: Proactively fix pow2floor(), switch to unsigned, Dr. David Alan Gilbert (git), 2017/09/06
- [Qemu-devel] [PULL 4/8] host-utils: Simplify pow2ceil(), Dr. David Alan Gilbert (git), 2017/09/06
- [Qemu-devel] [PULL 2/8] xbzrle: Drop unused cache_resize(), Dr. David Alan Gilbert (git), 2017/09/06
- [Qemu-devel] [PULL 5/8] runstate/migrate: Two more transitions, Dr. David Alan Gilbert (git), 2017/09/06
- [Qemu-devel] [PULL 7/8] snapshot/tests: Try loadvm twice, Dr. David Alan Gilbert (git), 2017/09/06
- [Qemu-devel] [PULL 6/8] migration: Reset rather than destroy main_thread_load_event, Dr. David Alan Gilbert (git), 2017/09/06
- [Qemu-devel] [PULL 8/8] migration: dump str in migrate_set_state trace,
Dr. David Alan Gilbert (git) <=
- Re: [Qemu-devel] [PULL 0/8] migration queue, Peter Maydell, 2017/09/07