Re: [Qemu-devel] [PATCH v3 2/2] watchdog: Allow setting action on the fly

[Daniel P. Berrange]

On Wed, Sep 06, 2017 at 10:58:54AM +0200, Michal Privoznik wrote:
> Currently, the only time that users can set watchdog action is at
> the start as all we expose is this -watchdog-action command line
> argument. This is suboptimal when users want to plug the device
> later via monitor. Alternatively, they might want to change the
> action for already existing device on the fly.
> 
> At the same time, drop local redefinition of the actions enum in
> watchdog.h in favour of the ones defined in schema and thus kills
> code duplication.

Nit-pick - I'd suggest 2 separat patches - one that drops the enum
redefinition, and the second which adds the new monitor command.
That way you separate no-op refactoring, from new features.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|