Re: [Qemu-devel] [PULL v2 13/47] tests/check-qlit: New, covering qobject/qlit.c

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 09/01/2017 10:37 AM, Markus Armbruster wrote:
>> From: Marc-André Lureau <address@hidden>
>> 
>> Signed-off-by: Marc-André Lureau <address@hidden>
>> Message-Id: <address@hidden>
>> [Copyright notice correction squashed in, commit message tweaked]
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  tests/Makefile.include |  5 +++-
>>  tests/check-qlit.c     | 64 
>> ++++++++++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 68 insertions(+), 1 deletion(-)
>>  create mode 100644 tests/check-qlit.c
>
> Adds a new file that is not covered by tests/.gitignore when doing an
> in-tree build

Easy enough to fix.

>               (and is one of our few check-* names that stands out in
> comparison to the bulk of the tests named test-* or *-test).

It's called check-lit.c because to match the related tests check-qlit.c
check-qdict.c check-qnull.c check-qstring.c check-qjson.c check-qnum.c
check-qlist.c.

> Of course, the point may be moot if we take the patch for
> auto-generating tests/.gitignore on an in-tree build...