[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH] osdep.h: Prohibit disabling assert() in sup
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC PATCH] osdep.h: Prohibit disabling assert() in supported builds |
Date: |
Tue, 5 Sep 2017 14:45:09 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 08/21/2017 05:08 AM, Peter Maydell wrote:
> On 21 August 2017 at 10:31, Markus Armbruster <address@hidden> wrote:
>> I'm fine with project-wide, but does it have to be a hard error? Can we
>> make it a warning? Same effect by default, but it lets people
>> experiment more easily with --disable-werror.
>
> It won't be the same effect by default for our releases, which
> don't use -Werror.
>
> I don't think we want to make it easy for people to turn this
> off -- and it's only commenting out a single #error line if
> anybody really does want to mess about with it.
Two lines, actually, since we are also prohibiting disabling g_assert().
Anyways, as the topic came up again on the list, should I promote this
patch from RFC to actual patch? Whose tree would it go in through?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [RFC PATCH] osdep.h: Prohibit disabling assert() in supported builds,
Eric Blake <=