[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vhost-user: disable broken test
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH] vhost-user: disable broken test |
Date: |
Tue, 5 Sep 2017 18:17:46 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Tue, Sep 05, 2017 at 02:08:22PM -0300, Philippe Mathieu-Daudé wrote:
> tests/vhost-user-test keeps failing on build-system since Aug 15:
>
> ERROR:tests/vhost-user-test.c:835:test_flags_mismatch: child process
> (/i386/vhost-user/flags-mismatch/subprocess [4836]) failed unexpectedly
> ...
> ERROR:tests/vhost-user-test.c:807:test_connect_fail: child process
> (/x86_64/vhost-user/connect-fail/subprocess [58910]) failed unexpectedly
Seems like it is always the subprocess tests which fail
from what I see. So rather than disable the entire test,
just put
if (1) {
g_test_skip("Skipping unreliable subprocess test");
return;
}
at the top of each test_*_subprocess() method
>
> The test can still be build for debug session using:
>
> $ FORCE_VHOST_USER_NET_TEST=1 ./configure ...
>
> Suggested-by: Peter Maydell <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> configure | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index fb7e34a901..d3b895b167 100755
> --- a/configure
> +++ b/configure
> @@ -6386,7 +6386,12 @@ if supported_kvm_target $target; then
> if test "$vhost_net" = "yes" ; then
> echo "CONFIG_VHOST_NET=y" >> $config_target_mak
> if test "$vhost_user" = "yes" ; then
> - echo "CONFIG_VHOST_USER_NET_TEST_$target_name=y" >>
> $config_host_mak
> + if test -n "${FORCE_VHOST_USER_NET_TEST}"; then
> + echo "CONFIG_VHOST_USER_NET_TEST_$target_name=y" >>
> $config_host_mak
> + elif test -z "${VHOST_USER_NET_TEST_WARNED}"; then
> + echo "warning: vhost-user tests disabled" >&2
> + VHOST_USER_NET_TEST_WARNED="warned"
> + fi
> fi
> fi
> fi
> --
> 2.14.1
>
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|