[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] snapshot/tests: Try loadvm twice
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] snapshot/tests: Try loadvm twice |
Date: |
Tue, 5 Sep 2017 12:32:27 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
* Peter Xu (address@hidden) wrote:
> On Fri, Aug 25, 2017 at 03:19:40PM +0100, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> >
> > It's legal to loadvm twice, modify the existing save/loadvm test
> > to do it twice.
> >
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
>
> Reviewed-by: Peter Xu <address@hidden>
>
> (a question below though)
>
> > ---
> > tests/qemu-iotests/068 | 2 +-
> > tests/qemu-iotests/068.out | 4 ++++
> > 2 files changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/qemu-iotests/068 b/tests/qemu-iotests/068
> > index cfa0f2aed5..e7fca6a494 100755
> > --- a/tests/qemu-iotests/068
> > +++ b/tests/qemu-iotests/068
> > @@ -78,7 +78,7 @@ for extra_args in \
> > # Give qemu some time to boot before saving the VM state
> > { sleep 1; printf "savevm 0\nquit\n"; } | _qemu $extra_args
> > # Now try to continue from that VM state (this should just work)
> > - echo quit | _qemu $extra_args -loadvm 0
> > + { sleep 1; printf "loadvm 0\nloadvm 0\nquit\n"; } | _qemu $extra_args
> > -S
>
> Curious about why there are both "sleep 1" and "-S" added - I thought
> "-S" means CPU won't really run, then why wait for one more second?
Mostly because I copied it from the savevm line above :-)
Dave
> > done
> >
> > # success, all done
> > diff --git a/tests/qemu-iotests/068.out b/tests/qemu-iotests/068.out
> > index aa063cf711..f07a938a38 100644
> > --- a/tests/qemu-iotests/068.out
> > +++ b/tests/qemu-iotests/068.out
> > @@ -7,6 +7,8 @@ QEMU X.Y.Z monitor - type 'help' for more information
> > (qemu) savevm 0
> > (qemu) quit
> > QEMU X.Y.Z monitor - type 'help' for more information
> > +(qemu) loadvm 0
> > +(qemu) loadvm 0
> > (qemu) quit
> >
> > === Saving and reloading a VM state to/from a qcow2 image (-object
> > iothread,id=iothread0 -set device.hba0.iothread=iothread0) ===
> > @@ -16,5 +18,7 @@ QEMU X.Y.Z monitor - type 'help' for more information
> > (qemu) savevm 0
> > (qemu) quit
> > QEMU X.Y.Z monitor - type 'help' for more information
> > +(qemu) loadvm 0
> > +(qemu) loadvm 0
> > (qemu) quit
> > *** done
> > --
> > 2.13.5
> >
>
> --
> Peter Xu
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 2/2] snapshot/tests: Try loadvm twice,
Dr. David Alan Gilbert <=