|
From: | Thomas Huth |
Subject: | Re: [Qemu-devel] [PATCH v6 25/29] wdt_ib700-test: Drop dependence on global_qtest |
Date: | Tue, 5 Sep 2017 13:01:20 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 01.09.2017 20:03, Eric Blake wrote: > As a general rule, we prefer avoiding implicit global state > because it makes code harder to safely copy and paste without > thinking about the global state. Improve this test to be > explicit about the state. > > Signed-off-by: Eric Blake <address@hidden> > --- > tests/wdt_ib700-test.c | 63 > +++++++++++++++++++++++++++----------------------- > 1 file changed, 34 insertions(+), 29 deletions(-) Reviewed-by: Thomas Huth <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |