[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v1 9/9] io: fix check for handshake completion in TLS
From: |
Daniel P. Berrange |
Subject: |
[Qemu-devel] [PULL v1 9/9] io: fix check for handshake completion in TLS test |
Date: |
Tue, 5 Sep 2017 10:22:30 +0100 |
The TLS I/O channel test had mistakenly used && instead
of || when checking for handshake completion. As a
result it could terminate the handshake process before
it had actually completed. This was harmless before but
changes in GNUTLS 3.6.0 exposed this bug and caused the
test suite to fail.
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>
---
tests/test-io-channel-tls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/test-io-channel-tls.c b/tests/test-io-channel-tls.c
index ff96877323..a210d01ba5 100644
--- a/tests/test-io-channel-tls.c
+++ b/tests/test-io-channel-tls.c
@@ -218,7 +218,7 @@ static void test_io_channel_tls(const void *opaque)
mainloop = g_main_context_default();
do {
g_main_context_iteration(mainloop, TRUE);
- } while (!clientHandshake.finished &&
+ } while (!clientHandshake.finished ||
!serverHandshake.finished);
g_assert(clientHandshake.failed == data->expectClientFail);
--
2.13.5
- [Qemu-devel] [PULL v1 0/9] Merge QEMU I/O 2017/09/05, Daniel P. Berrange, 2017/09/05
- [Qemu-devel] [PULL v1 3/9] sockets: factor out a new try_bind() function, Daniel P. Berrange, 2017/09/05
- [Qemu-devel] [PULL v1 4/9] sockets: factor out create_fast_reuse_socket, Daniel P. Berrange, 2017/09/05
- [Qemu-devel] [PULL v1 1/9] io: fix temp directory used by test-io-channel-tls test, Daniel P. Berrange, 2017/09/05
- [Qemu-devel] [PULL v1 7/9] io: fix typo in docs comment for qio_channel_read, Daniel P. Berrange, 2017/09/05
- [Qemu-devel] [PULL v1 2/9] tests: Add test-listen - a stress test for QEMU socket listen, Daniel P. Berrange, 2017/09/05
- [Qemu-devel] [PULL v1 6/9] util: remove the obsolete non-blocking connect, Daniel P. Berrange, 2017/09/05
- [Qemu-devel] [PULL v1 5/9] sockets: Handle race condition between binds to the same port, Daniel P. Berrange, 2017/09/05
- [Qemu-devel] [PULL v1 9/9] io: fix check for handshake completion in TLS test,
Daniel P. Berrange <=
- [Qemu-devel] [PULL v1 8/9] io: add new qio_channel_{readv, writev, read, write}_all functions, Daniel P. Berrange, 2017/09/05
- Re: [Qemu-devel] [PULL v1 0/9] Merge QEMU I/O 2017/09/05, Peter Maydell, 2017/09/05