[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] wm8750: add record buffer underrun check
|
From: |
P J P |
|
Subject: |
Re: [Qemu-devel] [PATCH] wm8750: add record buffer underrun check |
|
Date: |
Tue, 5 Sep 2017 00:07:02 +0530 (IST) |
+-- On Fri, 1 Sep 2017, Gerd Hoffmann wrote --+
| diff --git a/hw/audio/wm8750.c b/hw/audio/wm8750.c
| index f8b5bebfc2..d2bf2e1da1 100644
| --- a/hw/audio/wm8750.c
| +++ b/hw/audio/wm8750.c
| @@ -680,8 +680,12 @@ uint32_t wm8750_adc_dat(void *opaque)
| WM8750State *s = (WM8750State *) opaque;
| uint32_t *data;
|
| - if (s->idx_in >= sizeof(s->data_in))
| + if (s->idx_in >= sizeof(s->data_in)) {
| wm8750_in_load(s);
| + if (s->idx_in >= sizeof(s->data_in)) {
| + return 0x80008000; /* silence in AUD_FMT_S16 sample format */
| + }
| + }
|
| data = (uint32_t *) &s->data_in[s->idx_in];
| s->req_in -= 4;
Ack, looks good. Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F