[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 9/8] fixup! ppc: remove non implemented cpu m
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH v2 9/8] fixup! ppc: remove non implemented cpu models |
Date: |
Mon, 4 Sep 2017 21:10:54 +1000 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Wed, Aug 30, 2017 at 04:26:10PM +0200, Igor Mammedov wrote:
> only TODO escaped defines were meant to be removed,
> but not TODO_USER_ONLY which are compiled in case of
> *-user targets.
>
> So retirn back "440" model removed by mistake
>
> Spotted-by: Thomas Huth <address@hidden>
> Signed-off-by: Igor Mammedov <address@hidden>
I've applied patch 8 with this change folded in, so as not to break
bisect.
> ---
> target/ppc/cpu-models.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c
> index 611fc1b..08fb34b 100644
> --- a/target/ppc/cpu-models.c
> +++ b/target/ppc/cpu-models.c
> @@ -150,6 +150,10 @@
> POWERPC_DEF("x2vp20", CPU_POWERPC_X2VP20, 405,
> NULL)
> /* PowerPC 440 family
> */
> +#if defined(TODO_USER_ONLY)
> + POWERPC_DEF("440", CPU_POWERPC_440, 440GP,
> + "Generic PowerPC 440")
> +#endif
> /* PowerPC 440 cores
> */
> POWERPC_DEF("440-xilinx", CPU_POWERPC_440_XILINX, 440x5,
> "PowerPC 440 Xilinx 5")
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH v2 9/8] fixup! ppc: remove non implemented cpu models,
David Gibson <=