Re: [Qemu-devel] [PATCH v2] [WIP] [RFC ]Add initial 9pfs support for Windows hosts v2

[Greg Kurz]

On Mon, 28 Aug 2017 09:35:45 +0200
"Michael Fritscher" <address@hidden> wrote:

> Good day,
> 

Hi!

> only a short announcement: Sorry for the very long delay :-( But I'm
> working on this again. The biggest issue seems to be the *at stuff. I'll
> try to workaround this via getting the directories' path from the file
> descriptor with the /proc (as it is already done in the 9pfs_utils) -
> luckily,the mingw environment emulates the /proc. If this doesn't work
> I've another idea (the file descriptors needs to be "registered" with the
> path (and saved in a sparse vector or map with the fd as key and the path
> as value). The "big" solution would be to write a 9p_local_windows.c from
> scratch, but I would like to avoid it.
> 
> Additionally, I changed my approach: Instead of one big patch with
> everything in it, I split it into 2 patch series with several patches:
> 

I'd prefer to have a single series with all the patches because...

>   * The first one only fixes the build via adding #ifdefs, creating stubs
> in os-win32.h etc. and introduces no regressions. Status: Ready in my
> local repo: It compiles fine with enabled 9pfs and works. If 9pfs is
> tried to use there is a clean error message that the fsdev couldn't be
> initialized - as expected.
>   * The second one actually get 9pfs working. This involves mostly
> implementing the *at functions and a few tiny things (O_BINARY and so
> on) Status: Not started yet (will be at the next weekend I hope), but is
> a combination of parts of the the old patch + the implementation of the
> *at functions.
> 
> My hope is that the first series could be merged independently from the
> second. Meanings? If so I'll clean up the first patch series a bit

... I don't want to merge a bunch of code before I'm 100% sure the 9pfs
support on win32 is viable.

Cheers,

--
Greg

> (History cleaning) and send it to the list.
> 
> Best regards,
> Michael Fritscher
> 



-- 
Gregory Kurz                                     address@hidden
                                                 address@hidden
Software Engineer @ IBM/LTC                      http://www.ibm.com
Tel 33-5-6218-1607

"Anarchy is about taking complete responsibility for yourself."
        Alan Moore.